Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various crashing exceptions #531

Merged
merged 7 commits into from
Jan 6, 2025
Merged

fix: various crashing exceptions #531

merged 7 commits into from
Jan 6, 2025

Conversation

huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Jan 5, 2025

This pull request includes several changes to improve null safety and handle potential exceptions in the Screenbox.Core project.

  • Ignore all MRU related exceptions
  • Fix last position tracker uses the main storage list directly in an async save function. The list can change and cause enumeration exceptions.
  • Better null handling for Artist and Album details pages
  • Handle exception when trying to convert Uri into StorageFile
  • Check for CoreWebView2 is initialized before accessing to avoid null exception

@huynhsontung huynhsontung marked this pull request as ready for review January 6, 2025 07:17
@huynhsontung huynhsontung enabled auto-merge January 6, 2025 07:18
@huynhsontung huynhsontung merged commit f15bbd4 into main Jan 6, 2025
4 checks passed
@huynhsontung huynhsontung deleted the fixes branch January 6, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant